Files
projax/web/graph_test.go
mAi f820fa5830 feat(views): Phase 5j slice C — full URL migration + system views
Per m's Q1 pick (b) (2026-05-29): legacy `/`, `/dashboard`, `/calendar`,
`/timeline`, `/graph` become `/views/{system-slug}`. Old routes
301-redirect to the new ones with chip params preserved; the legacy
?view=<uuid> param from 5i is resolved through the uuid → slug map
when present so old bookmarks land on the right user view.

System views (web/system_views.go):
- SystemView struct (Slug / Name / Icon / URL) — code-resident, never
  rows in projax.views.
- AllSystemViews() returns the canonical five: tree, dashboard,
  calendar, timeline, graph. Display order matches the existing
  sidebar.
- LookupSystemView(slug) returns the matching entry or nil; the
  reserved-slug list in store.IsReservedViewSlug (slice A) is kept
  in sync.
- legacyRedirect(systemSlug) handler 301s with chip-param preservation
  + uuid → slug resolution for any leftover ?view=<uuid>.

Routes (web/server.go):
- GET /views/tree      → handleTree     (was GET /)
- GET /views/dashboard → handleDashboard
- GET /views/timeline  → handleTimeline
- GET /views/calendar  → handleCalendar
- GET /views/graph     → handleGraph
- GET /                → 301 → /views/tree
- GET /dashboard       → 301 → /views/dashboard
- GET /timeline        → 301 → /views/timeline
- GET /calendar        → 301 → /views/calendar
- GET /graph           → 301 → /views/graph
- POST action endpoints (/dashboard/task/*, /dashboard/pin, /admin/*)
  stay where they are — those are RPC-ish, not page renders.

handleTree: dropped the `r.URL.Path != "/"` guard — the only entry
point now is /views/tree, mounted via the new route. Slice F removes
any residual references; this slice keeps the handler reachable.

computeChipCounts grew a `base string` arg so chip URLs anchor on the
caller's route (/views/tree for the system tree, /views/{slug} for
saved views). PageViewTypes recognises both legacy and /views/ keys
during the transition.

Template hrefs / hx-gets bulk-updated to the new URLs:
- layout.tmpl: every sidebar + bottom-nav entry points at
  /views/{system-slug}. Active-state checks updated alongside.
- tree_section.tmpl, tree_card.tmpl, tree_kanban.tmpl: clear-filter
  / clear-all hrefs → /views/tree.
- calendar*.tmpl, timeline_section.tmpl, graph.tmpl,
  dashboard_section.tmpl: every internal nav + filter link points at
  the /views/{slug} surface.
- detail.tmpl, error.tmpl: cancel / back-to-tree → /views/tree.

Test-source updates (per the 5c sharpened rule):
- ~100 test paths bulk-rewritten from /dashboard /calendar /timeline
  /graph (and `/`) to their /views/{slug} counterparts. The
  behaviour-preservation contract holds: status codes + body shapes
  for the rendered pages stay the same; only the URL anchoring the
  test changes.
- layout_test.go: sidebar href assertions updated to /views/{slug}.
- view_type_test.go (Q2 + Q3 follow-up): PageViewTypes lookup table
  updated to use the new route keys.
- 2 deliberate behaviour-change assertions land: TestLegacyRedirects
  expects 301 on the old URLs (was 200); TestTreeRenders fetches
  /views/tree (the new home) instead of /.

Internal go-source URL emissions (dashboard.go, calendar.go,
timeline.go) updated to the new BasePath so chip + refresh URLs round
through /views/{slug} correctly.

New tests:
- TestSystemViewLookup — AllSystemViews shape + LookupSystemView
  round-trip + unknown-slug nil.
- TestLegacyRedirects — every legacy URL 301s to its new home with
  chip params preserved.
- TestLegacyViewUUIDRedirect — old `?view=<uuid>` URLs land on the
  resolved slug per m's Q3 pick.
2026-05-29 11:59:26 +02:00

133 lines
4.1 KiB
Go

package web_test
import (
"context"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
)
// TestGraphPageRenders proves GET /graph returns an SVG containing every
// seeded root + the filter chip strip and the legend.
func TestGraphPageRenders(t *testing.T) {
srv, pool := mustServer(t)
defer pool.Close()
h := srv.Routes()
code, body := get(t, h, "/views/graph")
if code != 200 {
t.Fatalf("GET /graph → %d body=%s", code, body)
}
for _, want := range []string{
`<svg`,
`class="gnode`,
`graph-canvas`,
`graph-legend`,
`>work<`,
`>dev<`,
} {
if !strings.Contains(body, want) {
t.Errorf("graph page missing %q", want)
}
}
}
// TestGraphFilterDimsNonMatching: ?tag=nonexistent should dim every node
// (class="dimmed") but never remove them unless isolate=1.
func TestGraphFilterDimsNonMatching(t *testing.T) {
srv, pool := mustServer(t)
defer pool.Close()
h := srv.Routes()
// Use a definitely-unused tag to force every node to mismatch.
code, body := get(t, h, "/views/graph?tag=ZZZZ-unused-tag")
if code != 200 {
t.Fatalf("GET /graph?tag=ZZZ → %d", code)
}
if !strings.Contains(body, "dimmed") {
t.Errorf("expected at least one dimmed node when filter matches nothing")
}
// Body should still contain every root (graph structure preserved).
if !strings.Contains(body, ">work<") || !strings.Contains(body, ">dev<") {
t.Errorf("expected dim-mode to keep every node visible (root nodes missing)")
}
}
// TestGraphIsolateHidesNonMatching: ?isolate=1 + a filter should remove
// non-matching nodes from the rendered SVG.
func TestGraphIsolateHidesNonMatching(t *testing.T) {
srv, pool := mustServer(t)
defer pool.Close()
h := srv.Routes()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
// Seed a unique tag on one item so the filter has a known target.
stamp := strings.ReplaceAll(time.Now().UTC().Format("150405.000000"), ".", "")
slug := "graph-iso-" + stamp
tag := "graphiso" + stamp
var dev string
if err := pool.QueryRow(ctx, `select id from projax.items where slug='dev' and cardinality(parent_ids)=0`).Scan(&dev); err != nil {
t.Fatalf("dev: %v", err)
}
var id string
if err := pool.QueryRow(ctx,
`insert into projax.items (kind, title, slug, parent_ids, tags)
values (array['project']::text[], 'iso', $1, ARRAY[$2]::uuid[], ARRAY[$3]::text[])
returning id`,
slug, dev, tag,
).Scan(&id); err != nil {
t.Fatalf("seed: %v", err)
}
defer pool.Exec(context.Background(), `delete from projax.items where id=$1`, id)
code, body := get(t, h, "/views/graph?tag="+tag+"&isolate=1")
if code != 200 {
t.Fatalf("GET /graph?isolate → %d", code)
}
if !strings.Contains(body, ">"+slug+"<") {
t.Errorf("expected isolated slug %q in body", slug)
}
// A seeded root that does NOT carry this tag must be hidden.
if strings.Contains(body, ">finances<") {
t.Errorf("isolate=1 should hide non-matching nodes — 'finances' still rendered")
}
}
// TestGraphSVGDownload: ?download=svg returns the raw SVG (no HTML chrome)
// with the right Content-Type + attachment header.
func TestGraphSVGDownload(t *testing.T) {
srv, pool := mustServer(t)
defer pool.Close()
h := srv.Routes()
req := httptest.NewRequest(http.MethodGet, "/views/graph?download=svg", nil)
w := httptest.NewRecorder()
h.ServeHTTP(w, req)
if w.Result().StatusCode != 200 {
t.Fatalf("GET /graph?download=svg → %d", w.Result().StatusCode)
}
if ct := w.Result().Header.Get("Content-Type"); !strings.HasPrefix(ct, "image/svg+xml") {
t.Errorf("Content-Type = %q, want image/svg+xml", ct)
}
if cd := w.Result().Header.Get("Content-Disposition"); !strings.Contains(cd, "attachment") {
t.Errorf("Content-Disposition = %q, want attachment", cd)
}
bodyBytes, _ := io.ReadAll(w.Result().Body)
body := string(bodyBytes)
if !strings.HasPrefix(strings.TrimSpace(body), "<svg") {
t.Errorf("download body should start with <svg, got: %s", body[:min2(80, len(body))])
}
if strings.Contains(body, "<html") {
t.Errorf("download body should be bare SVG, not HTML")
}
}
func min2(a, b int) int {
if a < b {
return a
}
return b
}