mAi
d3c28009de
Implements three Tier 3 primitives from curie's bulletproof completeness
audit (docs/research-deadlines-completeness-2026-05-25.md §10 T3.1, T3.2,
T3.5), per m's 2026-05-25 15:29 steer to build the full primitives
instead of documenting workarounds.
Primitive 1 — duration_unit='working_days':
Calculator walks day-by-day skipping weekends + court holidays via
HolidayService.IsNonWorkingDay. Event day is not counted; result is
always a working day for the (country, regime). Unlocks T1.8/T1.9
modeling and the R.198 / R.213 alt leg.
Primitive 2 — combine_op='max' (and 'min'):
When alt_duration_value + alt_duration_unit + combine_op are set, the
calculator evaluates both legs and picks the later (max) or earlier
(min) of the two adjusted end dates. The DB already had two rules
shaped this way ('31d OR 20wd, whichever is longer' — R.198 / R.213);
the calculator was silently dropping the alt leg.
Primitive 5 — timing='before' backward snap-to-working-day:
For backward rules (R.109.1: 1 month before oral hearing; R.109.4:
2 weeks before) the calculator now snaps to the PRECEDING working day
when the computed cut-off lands on a weekend/holiday. Forward snap
(the prior behavior) would push the cut-off past the statutory limit
and miss the deadline. Adds HolidayService.AdjustForNonWorkingDays-
Backward as the symmetric counterpart of AdjustForNonWorkingDays.
Migration 128 — DB schema:
Adds CHECK constraints on deadline_rules.duration_unit and
alt_duration_unit pinning the allowed set to days/weeks/months/
working_days. Live data audited and passes (no rows excluded).
Tests (12 new + 1 flipped):
- 5 working_days cases: forward over weekend, 20wd anchored on Fri,
across Karfreitag/Ostermontag, across year boundary, backward
from Friday, anchored on Saturday.
- 2 backward snap cases: Sun → preceding Fri; cluster Sun → Sat →
Karfreitag → Thu.
- 4 combine_op cases: max with primary winning, max with alt winning
over Christmas+Neujahr cluster, min with primary winning, NULL-alt
short-circuit.
- TestCalculateEndDate_BeforeTiming renamed and flipped from forward
(Sun → Mon, the prior wrong behavior) to backward (Sun → Fri).
No regression on existing rules: every pre-existing days/weeks/months
'after' rule still computes the same date. Frontend build + full
go test ./internal/... clean.
Slot 128 assigned per next-available convention (mig 127 = Wave 0
Tier-0 fixes, mig 128 = Wave 2 Tier-3 Slice A primitives).
37 lines
1.7 KiB
SQL
37 lines
1.7 KiB
SQL
-- t-paliad-271 Wave 2 Tier-3 Slice A — duration_unit CHECK constraint with
|
|
-- 'working_days' added to the allowed set.
|
|
--
|
|
-- Per docs/research-deadlines-completeness-2026-05-25.md Tier 3 Primitive 1
|
|
-- (T3.1) — the calculator gains a business-day arithmetic path for UPC RoP
|
|
-- R.198 / R.213 (and downstream for any rule that needs the 31d-OR-20wd
|
|
-- combine-max pattern). The schema currently accepts free-text on
|
|
-- duration_unit (no CHECK), which is why 'working_days' rows already exist
|
|
-- in the DB but were silently dropped by the calculator. Adding the CHECK
|
|
-- pins the contract and prevents typos.
|
|
--
|
|
-- alt_duration_unit gets the same constraint (NULL-tolerant) so the alt
|
|
-- path stays in lockstep with the primary path.
|
|
--
|
|
-- Idempotent: DROP CONSTRAINT IF EXISTS before ADD. Existing data was
|
|
-- audited via `SELECT DISTINCT duration_unit FROM paliad.deadline_rules`
|
|
-- on 2026-05-25 (returned only days/weeks/months) plus the two live
|
|
-- alt-unit rows already at 'working_days' — both shapes pass.
|
|
--
|
|
-- audit_reason set_config is NOT needed for DDL (mig 079 trigger fires on
|
|
-- INSERT/UPDATE/DELETE on the rows, not on ALTER TABLE).
|
|
|
|
ALTER TABLE paliad.deadline_rules
|
|
DROP CONSTRAINT IF EXISTS deadline_rules_duration_unit_check;
|
|
|
|
ALTER TABLE paliad.deadline_rules
|
|
ADD CONSTRAINT deadline_rules_duration_unit_check
|
|
CHECK (duration_unit IN ('days', 'weeks', 'months', 'working_days'));
|
|
|
|
ALTER TABLE paliad.deadline_rules
|
|
DROP CONSTRAINT IF EXISTS deadline_rules_alt_duration_unit_check;
|
|
|
|
ALTER TABLE paliad.deadline_rules
|
|
ADD CONSTRAINT deadline_rules_alt_duration_unit_check
|
|
CHECK (alt_duration_unit IS NULL
|
|
OR alt_duration_unit IN ('days', 'weeks', 'months', 'working_days'));
|