m/paliad
1
0
Fork 0
Code Issues 146 Pull Requests 8 Actions 3 Packages Projects Releases Wiki Activity
Files
0f3c30a64784b81f2b24833bb24958bc683f2cb2
paliad/pkg/litigationplanner/embedded/upc/holidays.json
mAi 39353d49ed fix(litigationplanner): UPC vacations no longer block deadlines (align with paliad t-paliad-121) 
youpc.org/deadlines was rolling a deadline "from 2027-01-02 (UPC Winter
Vacation)" — i.e. across the UPC judicial vacation as if it were a
public holiday. Paliad-side t-paliad-121 already decided vacations are
informational only (the Court keeps running through them, RoP / UPC AC
decision-on-judicial-vacation 2023-05-26), and `HolidayService.Is
NonWorkingDay` in `internal/services/holidays.go` is correct. The
embedded snapshot consumed by youpc.org via Go-module replace had
drifted: `pkg/litigationplanner/embedded/upc/holidays.go:74` blocked on
both `isClosure()` AND `isVacation()`.

This commit aligns the embedded calendar with the paliad-side semantics
and ships a fresh holiday set so the existing 2026/2027 fix actually
takes effect downstream.

Code changes (`holidays.go`):

- `IsNonWorkingDay`: drop the `|| h.isVacation()` branch — only weekends
  and `isClosure()` rows trigger the roll. Godoc rewritten to mirror
  the paliad-side rationale (Court keeps operating, RoP cites,
  vacation rows kept for informational labels).
- `isClosure()`: accept both `"public_holiday"` and `"closure"`. Live
  paliad DB rows use the `public_holiday` value; the placeholder
  snapshot shipped with the original Slice C used `closure` as a
  hand-crafted synonym. Reconciles with
  `internal/services/holidays.go:132` which already does the same
  union. Required to make the regenerated JSON (full of
  `public_holiday`) keep blocking DE national holidays after the
  regeneration in this commit.
- Type-level godoc updated: `SnapshotHolidayCalendar` now documents
  vacation-is-informational, and the `AdjustForNonWorkingDaysWithReason`
  precedence note explains that `vacation` kind only fires when a
  vacation row overlaps a weekend or closure that's already doing the
  rolling.

Data refresh (`holidays.json`):

- Regenerated from paliad prod (postgres @ 100.99.98.201:11833,
  paliad schema). 55 rows for 2026 + 2027: 22 DE public_holiday +
  33 UPC vacation (25 Summer Vacation Jul 27–Aug 28, 8 Winter
  Vacation Dec 24/28–31 + Jan 4–6). The previous placeholder shipped
  only 5 rows (3 Sommerpause + Neujahr + Tag der Arbeit, no Winter
  Vacation at all) — which is why a date landing in late Dec / early
  Jan landed inside an unmodeled gap on the consumer side.
- `meta.json` bumped: version → `2026-05-27-1-holidays-only`,
  `holiday_count` 5 → 55, `source_db_label` flags that only
  holidays.json was refreshed (see friction note below).

Regression test (`snapshot_test.go::TestSnapshotHolidayCalendar`):

- 2026-08-04 (Tue, UPC Summer Vacation) — `IsNonWorkingDay` must be
  false; `AdjustForNonWorkingDays` must NOT mutate the date.
- 2027-01-02 (Sat, m's flagged scenario) — must roll forward through
  Sat/Sun, then STOP on Mon 2027-01-04 (UPC Winter Vacation, no longer
  blocking). Pre-fix this rolled all the way to Thu 2027-01-07.

Cross-repo: youpc.org imports `pkg/litigationplanner` via Go-module
replace; the regenerated snapshot ships on its next rebuild. No
separate youpc.org commit needed — paliad is the source of truth.

Friction note: `cmd/gen-upc-snapshot/main.go` itself is incompatible
with the current paliad schema. Migration 140 (`140_drop_deadline_rules`)
dropped `paliad.deadline_rules`, but the generator still SELECTs from
it (main.go ~L162). Running the tool against prod fails on the rules
step. I bypassed the broken path and generated `holidays.json` directly
from the DB via psql + jq (same JSON shape that `EmbeddedHoliday`
expects, nulls filtered for `omitempty`). The other snapshot files
(rules.json, proceeding_types.json, trigger_events.json, courts.json)
remain at their pre-existing placeholder state — re-flagged in
meta.json's `source_db_label`. Refitting the generator for the post-
mig-140 schema is a separate task.

go vet + go test ./... clean (256+ Go tests pass, including the new
regression cases).
2026-05-27 15:04:05 +02:00

333 lines
6.6 KiB
JSON
Raw Blame History

[
{
"date": "2026-01-01",
"name": "Neujahr",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-04-03",
"name": "Karfreitag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-04-05",
"name": "Ostersonntag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-04-06",
"name": "Ostermontag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-05-01",
"name": "Tag der Arbeit",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-05-14",
"name": "Christi Himmelfahrt",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-05-24",
"name": "Pfingstsonntag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-05-25",
"name": "Pfingstmontag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-07-27",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-07-28",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-07-29",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-07-30",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-07-31",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-03",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-04",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-05",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-06",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-07",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-10",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-11",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-12",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-13",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-14",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-17",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-18",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-19",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-20",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-21",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-24",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-25",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-26",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-27",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-08-28",
"name": "UPC Summer Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-10-03",
"name": "Tag der Deutschen Einheit",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-12-24",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-12-25",
"name": "1. Weihnachtstag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-12-26",
"name": "2. Weihnachtstag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2026-12-28",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-12-29",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-12-30",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2026-12-31",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2027-01-01",
"name": "Neujahr",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-01-04",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2027-01-05",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2027-01-06",
"name": "UPC Winter Vacation",
"regime": "UPC",
"holiday_type": "vacation"
},
{
"date": "2027-03-26",
"name": "Karfreitag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-03-28",
"name": "Ostersonntag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-03-29",
"name": "Ostermontag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-05-01",
"name": "Tag der Arbeit",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-05-06",
"name": "Christi Himmelfahrt",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-05-16",
"name": "Pfingstsonntag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-05-17",
"name": "Pfingstmontag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-10-03",
"name": "Tag der Deutschen Einheit",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-12-25",
"name": "1. Weihnachtstag",
"country": "DE",
"holiday_type": "public_holiday"
},
{
"date": "2027-12-26",
"name": "2. Weihnachtstag",
"country": "DE",
"holiday_type": "public_holiday"
}
]
Reference in New Issue View Git Blame Copy Permalink