m/paliad
1
0
Fork 0
Code Issues 146 Pull Requests 8 Actions 1 Packages Projects Releases Wiki Activity

Termine: drop the 'From Today' / 'Ab heute' option (it's still showing past events) — pick a sensible default that hides past #54

New Issue
Open
opened 2026-05-20 11:59:25 +00:00 by mAi · 1 comment
mAi commented 2026-05-20 11:59:25 +00:00
Collaborator
Copy Link

Trigger

m 2026-05-20 13:58:

the 'From Today' Option is weird — it probably should not exist. It shows incl. past...

What happened

Fix 92780cf (2026-05-19) added a status=upcoming option for appointments + made it the default. Backend DeadlineFilterUpcoming is defined on the deadlines service (internal/services/deadline_service.go:132), not on appointments. The frontend sends status=upcoming for appointments, the backend appointment query doesn't have a matching case, so it falls through to the unfiltered path — past events come through.

What to do

  1. Drop the 'From Today' / 'Ab heute' option from the appointment status filter — confusing label that doesn't deliver.
  2. Pick a sensible default that hides past events. Candidates:
    • (R) Default to today (today's appointments) — most lawyer-relevant view; matches the dashboard tile.
    • this_week — broader; comfortable for planning.
    • 'All upcoming' with a real backend filter (start_at >= today) — would be the original intent of the dropped option, done right.
  3. If we keep an 'all upcoming' bucket, wire it on the backend properly: start_at >= NOW()::date in the appointment query path.
  4. Keep 'Alle (auch vergangene)' / 'All (incl. past)' as an explicit opt-in at the bottom of the list — never the default.

Out of scope

  • Calendar-view rendering changes (separate issue).
  • Status options for deadlines (they default to 'pending' which is unrelated).

Role

coder direct — clear bug + clear fix; pick the new default, wire backend filter if needed, remove dead option. Group with other UI cleanups.

## Trigger m 2026-05-20 13:58: > the 'From Today' Option is weird — it probably should not exist. It shows incl. past... ## What happened Fix `92780cf` (2026-05-19) added a `status=upcoming` option for appointments + made it the default. Backend `DeadlineFilterUpcoming` is defined on the **deadlines** service (`internal/services/deadline_service.go:132`), not on appointments. The frontend sends `status=upcoming` for appointments, the backend appointment query doesn't have a matching case, so it falls through to the unfiltered path — past events come through. ## What to do 1. **Drop the 'From Today' / 'Ab heute' option** from the appointment status filter — confusing label that doesn't deliver. 2. **Pick a sensible default** that hides past events. Candidates: - **(R)** Default to `today` (today's appointments) — most lawyer-relevant view; matches the dashboard tile. - `this_week` — broader; comfortable for planning. - 'All upcoming' with a real backend filter (`start_at >= today`) — would be the original intent of the dropped option, done right. 3. If we keep an 'all upcoming' bucket, wire it on the backend properly: `start_at >= NOW()::date` in the appointment query path. 4. Keep 'Alle (auch vergangene)' / 'All (incl. past)' as an explicit opt-in at the bottom of the list — never the default. ## Out of scope - Calendar-view rendering changes (separate issue). - Status options for deadlines (they default to 'pending' which is unrelated). ## Role **coder direct** — clear bug + clear fix; pick the new default, wire backend filter if needed, remove dead option. Group with other UI cleanups.
mAi self-assigned this 2026-05-20 11:59:25 +00:00
mAi commented 2026-05-20 12:44:38 +00:00
Author
Collaborator
Copy Link

Shipped via euler's batch on mai/euler/coder-small-ux-polish, merged into main at https://mgit.msbls.de/m/paliad/commit/a5ae214. Live after next Dokploy deploy.

Shipped via euler's batch on `mai/euler/coder-small-ux-polish`, merged into main at https://mgit.msbls.de/m/paliad/commit/a5ae214. Live after next Dokploy deploy.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
deferred
Parked — not pursuing now, may un-park later
done
Work completed by an agent; awaiting m to close
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mAi m
No Assignees mAi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: m/paliad#54
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?